linux-kernel - Re: [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with via-cuda driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1701031010300.20542@nippy.intranet>
Date:   Tue, 3 Jan 2017 11:33:21 +1100 (AEDT)
From:   Finn Thain <fthain@...egraphics.com.au>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-m68k@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with
 via-cuda driver


On Mon, 2 Jan 2017, Geert Uytterhoeven wrote:

> Hi Finn, Ben,
> 
> On Sun, Jan 1, 2017 at 1:56 AM, Finn Thain <fthain@...egraphics.com.au> 
> wrote:
> > Change the device probe test in the via-cuda.c driver so it will load 
> > on Egret-based machines too. Remove the now redundant via-maciisi.c 
> > driver.
> >
> > Tested-by: Stan Johnson <userm57@...oo.com> Signed-off-by: Finn Thain 
> > <fthain@...egraphics.com.au>
> 
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 

Thanks for your review.

> I guess this will go in with the rest of the series through Ben's 
> macintosh tree?
> 

Most of the recent patches in drivers/macintosh, including my 2015 
submission, commit 2dc710e93c ("macintosh/nvram: Remove as unused"), went 
through Michael's tree. But either tree would be fine with me.

BTW, to my knowledge there is no programmer's reference material for Cuda 
or Egret system controllers (excepting that which seems to be confined to 
Apple Inc). AIUI, Cuda was not part of CHRP. But one could observe all of 
the signalling between CPU and MCU by tracing the VIA I/O lines or doing 
the equivalent in a good emulator -- theoretically, of course. Would this 
be useful to reviewers?

-- 

> > ---
> >  arch/m68k/include/asm/macintosh.h |   2 +-
> >  arch/m68k/mac/config.c            |  18 +-
> >  arch/m68k/mac/misc.c              |  72 +---
> >  drivers/macintosh/Kconfig         |  24 +-
> >  drivers/macintosh/Makefile        |   1 -
> >  drivers/macintosh/adb.c           |   4 -
> >  drivers/macintosh/via-cuda.c      |   8 +-
> >  drivers/macintosh/via-maciisi.c   | 677 --------------------------------------
> >  8 files changed, 30 insertions(+), 776 deletions(-)
> >  delete mode 100644 drivers/macintosh/via-maciisi.c
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds