linux-kernel - Re: [RFC PATCH] sched: Remove set_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170103092459.GB3093@worktop>
Date:   Tue, 3 Jan 2017 10:24:59 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     mingo@...nel.org, torvalds@...ux-foundation.org,
        catalin.marinas@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [RFC PATCH] sched: Remove set_task_state()

On Fri, Dec 30, 2016 at 10:17:53AM -0800, Davidlohr Bueso wrote:

> -			set_task_state(current, TASK_RUNNING);
> +			set_current_state(TASK_RUNNING);

Obviously good.

> -		set_task_state(tsk, TASK_UNINTERRUPTIBLE);
> +		set_current_state(TASK_UNINTERRUPTIBLE);

Not so much..


So while I fully support this move, should we not first clean up the
code and also remove all the local 'tsk = current' variables such that
all replacements end up being obvious?

In any case, would be good to hear from arm64 folks.