linux-kernel - Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1701031050510.28985@cbobk.fhfr.pm>
Date:   Tue, 3 Jan 2017 10:54:00 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Even Xu <even.xu@...el.com>
cc:     benjamin.tissoires@...hat.com, srinivas.pandruvada@...ux.intel.com,
        arnd@...db.de, gregkh@...uxfoundation.org,
        andriy.shevchenko@...el.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients
 driver

On Fri, 23 Dec 2016, Even Xu wrote:

[ ... snip ... ]
> +static ssize_t ishtp_cl_write(struct file *file, const char __user *ubuf,
> +	size_t length, loff_t *offset)
> +{
> +	struct ishtp_cl_miscdev *ishtp_cl_misc = file->private_data;
> +	struct ishtp_cl *cl;
> +	void *write_buf;
> +	struct ishtp_device *dev;
> +	int ret;
> +
> +	/* Non-blocking semantics are not supported */
> +	if (file->f_flags & O_NONBLOCK) {
> +		ret = -EINVAL;
> +		goto out_unlock;

When taking the error path here you'd try to unlock 
ishtp_cl_misc->cl_mutex before actually acquiring it.

-- 
Jiri Kosina
SUSE Labs