linux-kernel - Re: [PATCH] Staging: comedi: comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <743f9a68-81e6-4cb3-9654-65536f21a708@mev.co.uk>
Date:   Tue, 3 Jan 2017 10:48:59 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Jonathan Villatoro <lacho8713@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     H Hartley Sweeten <hsweeten@...ionengravers.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: comedi_compat32: fixed a syntax error

On 26/12/16 06:26, Jonathan Villatoro wrote:
> Fixed a syntax error in the function definition's parameter.

It's not really a syntax error, just a coding style issue.

>
> Signed-off-by: Jonathan Horacio Villatoro Córdoba <lacho8713@...il.com>
> ---
>  drivers/staging/comedi/comedi_compat32.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_compat32.h b/drivers/staging/comedi/comedi_compat32.h
> index 5ce77f3..91d15c6 100644
> --- a/drivers/staging/comedi/comedi_compat32.h
> +++ b/drivers/staging/comedi/comedi_compat32.h
> @@ -25,7 +25,7 @@
>  #ifdef CONFIG_COMPAT
>
>  struct file;
> -long comedi_compat_ioctl(struct file *, unsigned int cmd, unsigned long arg);
> +long comedi_compat_ioctl(struct file *f, unsigned int cmd, unsigned long arg);
>
>  #else /* CONFIG_COMPAT */
>
>

Thanks.  There is an earlier patch for this that hasn't been applied yet.

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2016-December/097854.html

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-