linux-kernel - Re: [PATCH] Staging: comedi: comedidev.h: Drop old style zero-length array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <511c9b00-d8b3-b552-dd54-a7fa0bd0f426@mev.co.uk>
Date:   Tue, 3 Jan 2017 10:56:58 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Cheah Kok Cheong <thrust73@...il.com>,
        hsweeten@...ionengravers.com, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: comedidev.h: Drop old style zero-length
 array

On 21/12/16 19:13, Cheah Kok Cheong wrote:
> According to Documentation/Changes, the minimum gcc version required
> to compile the kernel is 3.2 (this is probably outdated too).
>
> Signed-off-by: Cheah Kok Cheong <thrust73@...il.com>
> ---
>  drivers/staging/comedi/comedidev.h | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 0c7c37a..9713d96 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -612,12 +612,6 @@ extern const struct comedi_lrange range_unknown;
>
>  #define range_digital		range_unipolar5
>
> -#if __GNUC__ >= 3
> -#define GCC_ZERO_LENGTH_ARRAY
> -#else
> -#define GCC_ZERO_LENGTH_ARRAY 0
> -#endif
> -
>  /**
>   * struct comedi_lrange - Describes a COMEDI range table
>   * @length: Number of entries in the range table.
> @@ -631,7 +625,7 @@ extern const struct comedi_lrange range_unknown;
>   */
>  struct comedi_lrange {
>  	int length;
> -	struct comedi_krange range[GCC_ZERO_LENGTH_ARRAY];
> +	struct comedi_krange range[];
>  };
>
>  /**
>

Yes, that seems to be redundant.  Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-