linux-kernel - Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wpecxq37.fsf@linux.intel.com>
Date:   Tue, 03 Jan 2017 14:53:00 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Roger Quadros <rogerq@...com>, mathias.nyman@...el.com
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk


Hi,

Roger Quadros <rogerq@...com> writes:
> Mathias & Felipe,
>
> On 17/11/16 17:01, Roger Quadros wrote:
>> Hi,
>> 
>> Some XHCI controllers e.g. dwc3 based have a broken Port disable [1].
>> 
>> If the attached high-speed device is misbehaving, the USB stack typically
>> disables the port using the PED bit in PORTSC. For the controllers that
>> have broken port disable, the port fails to detect further attach/detach
>> events and so high-speed devices can no longer be enumerated on the
>> port. The workaround is to prevent port disable using PED on such
>> controllers.
>> 
>> We add a new BROKEN_PED quirk flag and 'quirk-broken-port-ped' device
>> property and prevent port disable using PED if we encounter the quirk flag.
>> 
>> [1] - AM572x Silicon Errata http://www.ti.com/lit/er/sprz429j/sprz429j.pdf
>>     Section i896— USB xHCI Port Disable Feature Does Not Work
>
> Any comments on this series?
> patch 1 is at v3. Rest 2 are original.

none from me. Mathias?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)