linux-kernel - Re: [PATCH v2 4/6] KVM: x86: refactor pic setup in kvm_set_routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Jan 2017 14:05:12 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Radim Krčmář <rkrcmar@...hat.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v2 4/6] KVM: x86: refactor pic setup in
 kvm_set_routing_entry

Am 16.12.2016 um 16:10 schrieb Radim Krčmář:
> Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>
> Signed-off-by: Radim Krčmář <rkrcmar@...hat.com>
> ---
>  v2: r-b Paolo
> ---
>  arch/x86/kvm/irq_comm.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
> index 6c0191615f23..1dfeb185a1e3 100644
> --- a/arch/x86/kvm/irq_comm.c
> +++ b/arch/x86/kvm/irq_comm.c
> @@ -297,15 +297,13 @@ int kvm_set_routing_entry(struct kvm *kvm,
>  	case KVM_IRQ_ROUTING_IRQCHIP:
>  		delta = 0;
>  		switch (ue->u.irqchip.irqchip) {
> +		case KVM_IRQCHIP_PIC_SLAVE:
> +			delta = 8;
> +			/* fall through */
>  		case KVM_IRQCHIP_PIC_MASTER:
>  			e->set = kvm_set_pic_irq;
>  			max_pin = PIC_NUM_PINS;
>  			break;
> -		case KVM_IRQCHIP_PIC_SLAVE:
> -			e->set = kvm_set_pic_irq;
> -			max_pin = PIC_NUM_PINS;
> -			delta = 8;
> -			break;
>  		case KVM_IRQCHIP_IOAPIC:
>  			max_pin = KVM_IOAPIC_NUM_PINS;
>  			e->set = kvm_set_ioapic_irq;
>

Had the exact same thing in mind when reading that piece of code.

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

David