linux-kernel - Re: [PATCH 6/7] perf record: Add switch-output size option argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170103144955.GH27864@kernel.org>
Date:   Tue, 3 Jan 2017 11:49:55 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, David Ahern <dsahern@...il.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Wang Nan <wangnan0@...wei.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 6/7] perf record: Add switch-output size option argument

Em Tue, Jan 03, 2017 at 03:32:32PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 03, 2017 at 11:20:27AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 03, 2017 at 09:19:59AM +0100, Jiri Olsa escreveu:
> > > It's now possible to specify the threshold size for
> > > perf.data like:
> > > 
> > >   $ perf record --switch-output=2G ...
> > > 
> > > Once it's reached, the current data are dumped in to the
> > > perf.data.<timestamp> file and session does on.
> > 
> >   s/does/goes/g
> > 
> > But:
> > 
> > [root@...et ~]# perf record -F9000 -a --switch-output=1K sleep 5
> > [ perf record: dump data: Woken up 0 times ]
> > [ perf record: Dump perf.data.2017010311185502 ]
> > [ perf record: dump data: Woken up 1 times ]
> > [ perf record: Dump perf.data.2017010311190003 ]
> > [ perf record: Woken up 0 times to write data ]
> > [ perf record: Dump perf.data.2017010311190020 ]
> > [ perf record: Captured and wrote 2.240 MB perf.data.<timestamp> ]
> > [root@...et ~]# ls -larth perf.data.*
> > -rw-------. 1 root root 2.3M Jan  3 11:18 perf.data.2017010311181984
> > -rw-------. 1 root root 2.3M Jan  3 11:18 perf.data.2017010311182002
> > -rw-------. 1 root root 2.3M Jan  3 11:18 perf.data.2017010311185502
> > -rw-------. 1 root root 2.3M Jan  3 11:19 perf.data.2017010311190003
> > -rw-------. 1 root root 2.3M Jan  3 11:19 perf.data.2017010311190020
> > [root@...et ~]#
> > 
> > What is that I am missing?
> 
> hum, I think the size you configured is smaller then the size
> of the shared kernel buffer and perf gets woken up by default
> only when we cross some level of data that's in.. would need
> to check
> 
> also I dont think 1K won't fit even the perf.data
> header.. are you trying to break it? ;-)

I'm trying to follow the documentation ;-) Your explanation sounds
reasonable, could you get this code to check those constraints and emit
a sensible error message?

- Arnaldo