linux-kernel - Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1483459942.9552.215.camel@linux.intel.com>
Date:   Tue, 03 Jan 2017 18:12:22 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Noralf Trønnes <noralf@...nnes.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation
 when DMA fails

On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote:
> Fall back to usual allocation method if DMA coherent allocation fails.
> 
> SPI framework will map and use DMA mapped memory when possible.

Locally I have re-done DMA approach and thus this patch became optional.

Should I leave or remove it? Opinions?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/staging/fbtft/fbtft-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-core.c
> b/drivers/staging/fbtft/fbtft-core.c
> index 226be8c09768..9f024986aff4 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -843,7 +843,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct
> fbtft_display *display,
>  		if (dma) {
>  			txbuf = dmam_alloc_coherent(dev, txbuflen,
>  						    &par->txbuf.dma,
> GFP_DMA);
> -		} else
> +		}
> +		if (!txbuf)
>  #endif
>  		{
>  			txbuf = devm_kzalloc(par->info->device,

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy