linux-kernel - Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170103164746.GA24790@kroah.com>
Date:   Tue, 3 Jan 2017 17:47:46 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Stuart Yoder <stuart.yoder@....com>
Cc:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "arnd@...db.de" <arnd@...db.de>, Roy Pledge <roy.pledge@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "agraf@...e.de" <agraf@...e.de>,
        Bogdan Hamciuc <bogdan.hamciuc@....com>,
        Laurentiu Tudor <laurentiu.tudor@....com>
Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file

On Tue, Dec 06, 2016 at 06:10:38PM +0000, Stuart Yoder wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > Sent: Tuesday, December 06, 2016 11:56 AM
> > To: Stuart Yoder <stuart.yoder@....com>
> > Cc: Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>; devel@...verdev.osuosl.org; linux-
> > kernel@...r.kernel.org; agraf@...e.de; arnd@...db.de; Alexandru Marginean <alexandru.marginean@....com>;
> > Bogdan Hamciuc <bogdan.hamciuc@....com>; Roy Pledge <roy.pledge@....com>; Laurentiu Tudor
> > <laurentiu.tudor@....com>
> > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file
> > 
> > On Tue, Dec 06, 2016 at 12:59:59PM +0000, Stuart Yoder wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > > > Sent: Tuesday, December 06, 2016 4:20 AM
> > > > To: Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>
> > > > Cc: devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org; agraf@...e.de; arnd@...db.de;
> > Alexandru
> > > > Marginean <alexandru.marginean@....com>; Bogdan Hamciuc <bogdan.hamciuc@....com>; Stuart Yoder
> > > > <stuart.yoder@....com>; Roy Pledge <roy.pledge@....com>; Laurentiu Tudor <laurentiu.tudor@....com>
> > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file
> > > >
> > > > On Tue, Dec 06, 2016 at 10:06:25AM +0000, Ruxandra Ioana Radulescu wrote:
> > > > > > -----Original Message-----
> > > > > > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > > > > > Sent: Tuesday, December 06, 2016 11:58 AM
> > > > > > To: Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>
> > > > > > Cc: devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org;
> > > > > > agraf@...e.de; arnd@...db.de; Alexandru Marginean
> > > > > > <alexandru.marginean@....com>; Bogdan Hamciuc
> > > > > > <bogdan.hamciuc@....com>; Stuart Yoder <stuart.yoder@....com>; Roy
> > > > > > Pledge <roy.pledge@....com>; Laurentiu Tudor
> > > > > > <laurentiu.tudor@....com>
> > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file
> > > > > >
> > > > > > On Tue, Dec 06, 2016 at 03:34:41AM -0600, Ioana Radulescu wrote:
> > > > > > > Add a list of TODO items for the Ethernet driver
> > > > > > >
> > > > > > > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@....com>
> > > > > > > ---
> > > > > > >  drivers/staging/fsl-dpaa2/ethernet/TODO |    9 +++++++++
> > > > > > >  1 files changed, 9 insertions(+), 0 deletions(-)
> > > > > > >  create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO
> > > > > > >
> > > > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/TODO b/drivers/staging/fsl-
> > > > > > dpaa2/ethernet/TODO
> > > > > > > new file mode 100644
> > > > > > > index 0000000..833265b
> > > > > > > --- /dev/null
> > > > > > > +++ b/drivers/staging/fsl-dpaa2/ethernet/TODO
> > > > > > > @@ -0,0 +1,9 @@
> > > > > > > +* Add a DPAA2 MAC kernel driver in order to allow PHY management;
> > > > > > currently
> > > > > > > +  the DPMAC objects and their link to DPNIs are handled by MC internally
> > > > > > > +  and all PHYs are seen as fixed-link
> > > > > > > +* add more debug support: decide how to expose detailed debug
> > > > > > statistics,
> > > > > > > +  add ingress error queue support
> > > > > > > +* MC firmware uprev; the DPAA2 objects used by the Ethernet driver
> > > > > > need to
> > > > > > > +  be kept in sync with binary interface changes in MC
> > > > > > > +* refine README file
> > > > > > > +* cleanup
> > > > > >
> > > > > > These seem like very minor things, why not just spend a week and do this
> > > > > > work and get it merged to the "correct" portion of the kernel tree?  Why
> > > > > > does this have to go into staging?
> > > > >
> > > > > Actually the first bullet is not minor at all and requires some design
> > > > > choices that we aren't yet completely clear with, and which in turn may
> > > > > affect parts of the Ethernet driver. We figured it would be best to try
> > > > > adding this in staging first (and also provide this way an example of using
> > > > > the fsl-mc bus and dpio driver) than wait until all MAC development
> > > > > questions are ironed-out.
> > > >
> > > > Ok, that makes sense.
> > > >
> > > > > I can remove the other bullets from the TODO list if you think they're
> > > > > not worth mentioning.
> > > >
> > > > No, they should be mentioned, I just didn't think they are all that much
> > > > work, and if you didn't have major things needed to get done, you could
> > > > just knock it all out in a week of local development.
> > > >
> > > > I'll look into taking this into the tree later today...
> > >
> > > Note, as mentioned in the cover letter, in it's current form this patch
> > > series is based on the series:
> > > [PATCH v3 0/9] staging: fsl-mc: move bus driver out of staging, add dpio
> > >
> > > ...which means that it won't build or run without that series being
> > > applied first, due to header file dependencies.  It also functionally
> > > depends on the DPIO driver.  So we need the dpio driver merged first.
> > >
> > > Is moving the fsl-mc bus driver out of staging a possibility now?
> > 
> > I'm ok with it, but I really haven't looked at the patches in a while, I
> > keep seeing others have problems with it.  Want me to review it now?
> 
> Yes, would like that very much.

Ok, basic driver model things, who is cleaning up your struct devices
when they go away?  Don't you get nasty warnings from the driver core
when the device is removed?

And you can't allocate a 'struct device' with devm_kzalloc(), that's
just crazy as the lifetime can not be owned by someone else for a
refernce counted object!

And finally, no one is calling dpmcp_destroy(), why is it there?

I think this needs a lot of driver model rework, sorry.  Please do that
before adding new drivers.

thanks,

greg k-h