linux-kernel - Re: [PATCH] tty: serial: msm: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170103185335.GK10531@minitux>
Date:   Tue, 3 Jan 2017 10:53:36 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, Jiri Slaby <jslaby@...e.com>,
        linux-arm-msm@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-soc@...r.kernel.org
Subject: Re: [PATCH] tty: serial: msm: Fix module autoload

On Mon 02 Jan 06:57 PST 2017, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/tty/serial/msm_serial.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/tty/serial/msm_serial.ko | grep alias
> alias:          of:N*T*Cqcom,msm-uartdmC*
> alias:          of:N*T*Cqcom,msm-uartdm
> alias:          of:N*T*Cqcom,msm-uartC*
> alias:          of:N*T*Cqcom,msm-uart
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
> 
>  drivers/tty/serial/msm_serial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index 7312e7e01b7e..6788e7532dff 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -1809,6 +1809,7 @@ static const struct of_device_id msm_match_table[] = {
>  	{ .compatible = "qcom,msm-uartdm" },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, msm_match_table);
>  
>  static struct platform_driver msm_platform_driver = {
>  	.remove = msm_serial_remove,
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html