lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 3 Jan 2017 22:12:18 +0200
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Alan Stern <stern@...land.harvard.edu>,
        Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

Hi,

On Tue, Jan 03, 2017 at 08:05:04PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote:
> > On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
> > > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
> > > > to be loaded to get the PHY going and ohci-omap should wait for those.
> > > > 
> > > > Signed-off-by: Aaro Koskinen <aaro.koskinen@....fi>
> > > 
> > > Is this a new bug?  The 770 has been around for forever, why has this
> > > not been a problem before now?
> > 
> > PHY/OTG support for 770 has been around only since v3.14.
> 
> 3.14 was released March, 2014.  A long time ago in kernel development :)
> 
> > I was previously compiling phy-tahvo as built-in, and bumped into this
> > issue when compiling it as a module.
> 
> Why not just make the defconfig as built-in?

I have reverted back to using built-in in my .config.

> I'm not objecting to this patch, just really curious why no one else has
> ever hit it.

Maybe I'm the only user...

The only other board using OHCI OMAP with PHY driver is H2/H3, and they
have solved the issue making USB_OHCI_HCD_OMAP1 depend on the PHY driver:

	depends on ISP1301_OMAP || !(MACH_OMAP_H2 || MACH_OMAP_H3)

This way modprobe will handle the loading order automatically.

BTW, I just realized the same issue is with omap_udc. So I guess this patch
should be just dropped, or resent so that both drivers are fixed.

A.

Powered by blists - more mailing lists