linux-kernel - Re: [PATCH 4/4] watchdog: iTCO_wdt: Simplify module init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2017 00:38:03 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH 4/4] watchdog: iTCO_wdt: Simplify module init function

On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> The 'ret' variable in iTCO_wdt_init_module() does not add any value;
> drop it.

Perhaps 'err', otherwise:
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/watchdog/iTCO_wdt.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index ad29ae03a30b..fc7712112412 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -612,15 +612,9 @@ static struct platform_driver iTCO_wdt_driver = {
>
>  static int __init iTCO_wdt_init_module(void)
>  {
> -       int err;
> -
>         pr_info("Intel TCO WatchDog Timer Driver v%s\n", DRV_VERSION);
>
> -       err = platform_driver_register(&iTCO_wdt_driver);
> -       if (err)
> -               return err;
> -
> -       return 0;
> +       return platform_driver_register(&iTCO_wdt_driver);
>  }
>
>  static void __exit iTCO_wdt_cleanup_module(void)
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko