linux-kernel - Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

message-id: <529b-586c3500-5-5e05b080@98620974>
date:   Tue, 03 Jan 2017 23:34:04 +0000
from:   "Peter Senna Tschudin" <peter.senna@...labora.co.uk>
to:     "Rob Herring" <robh@...nel.org>
cc:     jslaby@...e.cz, dri-devel@...ts.freedesktop.org,
        martyn.welch@...labora.co.uk, tiwai@...e.com,
        linux@...linux.org.uk, galak@...eaurora.org, peter.senna@...il.com,
        architt@...eaurora.org, "Fabio Estevam" <fabio.estevam@....com>,
        ijc+devicetree@...lion.org.uk, davem@...emloft.net,
        mark.rutland@....com, rmk+kernel@...linux.org.uk,
        kernel@...gutronix.de, enric.balletbo@...labora.com,
        mchehab@....samsung.com,
        "Peter Senna Tschudin" <peter.senna@...labora.com>,
        treding@...dia.com, gregkh@...uxfoundation.org,
        p.zabel@...gutronix.de, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, javier@...hile0.org,
        devicetree@...r.kernel.org, martin.donnelly@...com,
        shawnguo@...nel.org, linux-arm-kernel@...ts.infradead.org,
        eballetbo@...il.com, pawel.moll@....com, airlied@...ux.ie,
        ykk@...k-chips.com, heiko@...ech.de, thierry.reding@...il.com,
        daniel.vetter@...ll.ch, linux@...ck-us.net
subject: Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp

 Hi Rob,

Thank you for the review.

On 03 January, 2017 23:51 CET, Rob Herring <robh@...nel.org> wrote: 
 
> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote:
> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++
> > display bridge.
> > 
> > Cc: Martyn Welch <martyn.welch@...labora.co.uk>
> > Cc: Martin Donnelly <martin.donnelly@...com>
> > Cc: Javier Martinez Canillas <javier@...hile0.org>
> > Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: Fabio Estevam <fabio.estevam@....com>
> > Signed-off-by: Peter Senna Tschudin <peter.senna@...labora.com>
> > ---
> > There was an Acked-by from Rob Herring <robh@...nel.org> for V6, but I changed
> > the bindings to use i2c_new_secondary_device() so I removed it from the commit
> > message.
> > 
> >  .../devicetree/bindings/ge/b850v3-lvds-dp.txt      | 39 ++++++++++++++++++++++
> 
> Generally, bindings are not organized by vendor. Put in 
> bindings/display/bridge/... instead.

Will change that.

> 
> >  1 file changed, 39 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
> > new file mode 100644
> > index 0000000..1bc6ebf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
> > @@ -0,0 +1,39 @@
> > +Driver for GE B850v3 LVDS/DP++ display bridge
> > +
> > +Required properties:
> > +  - compatible : should be "ge,b850v3-lvds-dp".
> 
> Isn't '-lvds-dp' redundant? The part# should be enough.

b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output?

> 
> > +  - reg : should contain the main address which is used to ack the
> > +    interrupts and address for edid.
> > +  - reg-names : comma separeted list of register names. Valid values
> 
> s/separeted/separated/

argh, sorry for this. Will fix it.

> 
> > +    are "main", and "edid".
> > +  - interrupt-parent : phandle of the interrupt controller that services
> > +    interrupts to the device
> > +  - interrupts : one interrupt should be described here, as in
> > +    <0 IRQ_TYPE_LEVEL_HIGH>.
> > +  - port : should describe the video signal connection between the host
> > +    and the bridge.
> > +
> > +Example:
> > +
> > +&mux2_i2c2 {
> > +	status = "okay";
> > +	clock-frequency = <100000>;
> > +
> > +	b850v3-lvds-dp-bridge@73  {
> > +		compatible = "ge,b850v3-lvds-dp";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		reg = <0x73 0x72>;
> > +		reg-names = "main", "edid";
> > +
> > +		interrupt-parent = <&gpio2>;
> > +		interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > +		port {
> > +			b850v3_dp_bridge_in: endpoint {
> > +				remote-endpoint = <&lvds0_out>;
> > +			};
> > +		};
> > +	};
> > +};
> > -- 
> > 2.5.5
> >