linux-kernel - Re: [PATCH RESEND] power: gpio_charger: switch to using GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170104212046.egsccncbvaidioss@earth>
Date:   Wed, 4 Jan 2017 22:20:47 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        David Woodhouse <dwmw2@...radead.org>,
        Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH RESEND] power: gpio_charger: switch to using GPIO
 descriptors

Hi Linus,

On Mon, Dec 26, 2016 at 09:18:55PM +0100, Linus Walleij wrote:
> The GPIO charger is using a mix of the legacy GPIO interface
> and <linux/of_gpio.h> which is not the modern way to use GPIOs.
> 
> Refactor like this:
> 
> - Use a GPIO descriptor for the GPIO line used to monitor the
>   charger.
> - Fetch the descriptor with devm_gpiod_get() as the first
>   method.
> - If this fails and we are *not* using device tree, then
>   start looking to see if we can use platform data instead.
> - After looking up and requesting a GPIO number with the
>   legacy API, convert it to a descriptor.
> 
> This way we can later isolate and drop the legacy code as
> more platforms move over to using descriptors.
> 
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for your patch. I have queued it into power-supply's
for-next branch:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)