linux-kernel - Re: [PATCH v5 1/3] drm/exynos: mic: Add mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <a9e86290-ab21-409f-5be0-7b74bc401feb@samsung.com>
Date:   Wed, 04 Jan 2017 10:05:30 +0100
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Hoegeun Kwon <hoegeun.kwon@...sung.com>, robh@...nel.org,
        thierry.reding@...il.com, airlied@...ux.ie, kgene@...nel.org,
        krzk@...nel.org, inki.dae@...sung.com
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        cw00.choi@...sung.com, jh80.chung@...sung.com
Subject: Re: [PATCH v5 1/3] drm/exynos: mic: Add mode_set callback function

On 04.01.2017 09:15, Hoegeun Kwon wrote:
> Before applying the patch, used the of_get_videomode function to
> parse the display-timings in the panel which is the child driver
> of dsi in the devicetree. this is wrong. So removed the
> of_get_videomode and fixed to get videomode struct through
> mode_set callback function.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

Only one, non-blocking comment below.

> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index a0def0b..a0f459c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -286,13 +286,6 @@ static int parse_dt(struct exynos_mic *mic)
>  			}
>  			nodes[j++] = remote_node;
>  
> -			ret = of_get_videomode(remote_node,
> -							&mic->vm, 0);
> -			if (ret) {
> -				DRM_ERROR("mic: failed to get videomode");
> -				goto exit;
> -			}
> -

I think the whole parse_dt function should be refactored, but it can be
done later in separate patch.

Regards
Andrzej