linux-kernel - Re: [v1] gpu: drm: mgag200: mgag200_main:- Handle error from pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2017 10:15:50 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     airlied@...ux.ie, airlied@...hat.com, daniel.vetter@...ll.ch,
        seanpaul@...omium.org, chris@...is-wilson.co.uk,
        elfring@...rs.sourceforge.net, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v1] gpu: drm: mgag200: mgag200_main:- Handle error from
 pci_iomap

On Tue, Jan 03, 2017 at 05:00:27PM +0530, Arvind Yadav wrote:
> Here, pci_iomap can fail, handle this case and return -ENOMEM.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied to drm-misc, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/mgag200/mgag200_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c
> index e79cbc2..fb03e30 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_main.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_main.c
> @@ -145,6 +145,8 @@ static int mga_vram_init(struct mga_device *mdev)
>  	}
>  
>  	mem = pci_iomap(mdev->dev->pdev, 0, 0);
> +	if (!mem)
> +		return -ENOMEM;
>  
>  	mdev->mc.vram_size = mga_probe_vram(mdev, mem);
>  
> -- 
> 1.9.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch