linux-kernel - Re: [PATCH 2/3] lib: Add module support to glob tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vd6Y32BVPC13za0Lbmiiuju0oVkYU8tT1KHnOLxrqj7WQ@mail.gmail.com>
Date:   Wed, 4 Jan 2017 11:22:12 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Matt Domsch <Matt_Domsch@...l.com>,
        Luca Barbieri <luca@...a-barbieri.com>,
        George Spelvin <linux@...izon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] lib: Add module support to glob tests

On Tue, Jan 3, 2017 at 9:04 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> Extract the glob test code into its own source file, to allow to
> compile it either to a loadable module, or builtin into the kernel.

To the whole series
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

One minor comment below.

> +obj-$(CONFIG_GLOB_SELFTEST) += globtest.o

Can we use pattern test_*, or at least *_test.*?

-- 
With Best Regards,
Andy Shevchenko