linux-kernel - Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1701041032150.28985@cbobk.fhfr.pm>
Date:   Wed, 4 Jan 2017 10:36:18 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     "Xu, Even" <even.xu@...el.com>
cc:     "srinivas.pandruvada@...ux.intel.com" 
        <srinivas.pandruvada@...ux.intel.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>
Subject: Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients
 driver

On Wed, 4 Jan 2017, Xu, Even wrote:

> > [ ... snip ... ]
> > > 
> > > +static ssize_t ishtp_cl_write(struct file *file, const char __user
> > > *ubuf,
> > > +	size_t length, loff_t *offset)
> > > +{
> > > +	struct ishtp_cl_miscdev *ishtp_cl_misc = file-
> > > >private_data;
> > > +	struct ishtp_cl *cl;
> > > +	void *write_buf;
> > > +	struct ishtp_device *dev;
> > > +	int ret;
> > > +
> > > +	/* Non-blocking semantics are not supported */
> > > +	if (file->f_flags & O_NONBLOCK) {
> > > +		ret = -EINVAL;
> > > +		goto out_unlock;
> > When taking the error path here you'd try to unlock 
> > ishtp_cl_misc->cl_mutex before actually acquiring it.
> > 
> 
> Thanks for your comments, Jiri, I update my patch below:

Greg, how would you like to handle this (after you're done with reviewing 
it of course), given that this driver depends on the preceeding 6 patches 
to intel-ish-hid driver?

Thanks,

-- 
Jiri Kosina
SUSE Labs