linux-kernel - Re: [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2017 11:41:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Derek Robson <robsonde@...il.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions

On Wed, Jan 4, 2017 at 3:20 AM, Derek Robson <robsonde@...il.com> wrote:
> Fixed coding style issue, found with Checkpatch.pl
> changed permissions to octal style.

You missed SoB.

> @@ -37,7 +37,7 @@
>                         "3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
>
>  static bool emulate;
> -module_param(emulate, bool, 0);
> +module_param(emulate, bool, 0000);

Why not to allow reading as well?

>  MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");

-- 
With Best Regards,
Andy Shevchenko