linux-kernel - Re: [PATCH 00/12] Eberspaecher Flexcard PMC II base support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170104094350.GR27589@dell>
Date:   Wed, 4 Jan 2017 09:43:50 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Holger Dengler <dengler@...utronix.de>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vinod Koul <vinod.koul@...el.com>,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Juergen Bubeck <bubeck@...ug.com>,
        Peter Mahler <mahler@...ug.com>
Subject: Re: [PATCH 00/12] Eberspaecher Flexcard PMC II base support

On Wed, 14 Dec 2016, Holger Dengler wrote:

> 
> The Eberspaecher Flexcard PMC II is a PMC (PCI Mezzanine Card) II
> carrier board. The carrier board can take up to 4 exchangeable physical
> layer boards for CAN, FlexRay or Ethernet.
> This patchset adds support for the common infrastructure of the carrier
> board.
> 
> This patch series apply on v4.9.
> 
> First post:  http://www.spinics.net/lists/netdev/msg246290.html
> Second post: http://www.spinics.net/lists/kernel/msg1954275.html
> 
> According to the comments regarding our first posting, the MFD driver
> patchset has been split up into separate functional parts.
> 
> According to the comments regarding our second port, we moved the
> separated driver to their particular subsystems. All other comments
> are also reflected.
> 
> The timer functionality was wrongly named as clocksource in the second post,
> although it is a posix_clock. We renamed it and moved it together with the
> misc_device funtions to drivers/misc/. If someone know a better place for
> the posix_clock, please let me know.
> 
> The irq part of the mfd driver has been mainly reworked (thanks to Thomas
> and Sebastian for their input). The irq-demux is now implementet without a
> loop and the irq_chips share the irq-table and functions.
> 
> Holger Dengler (12):
>   mfd: Eberspaecher Flexcard PMC II Carrier Board support
>   mfd: flexcard: add flexcard misc mfd-cell
>   mfd: flexcard: add posix clock mfd-cell
>   mfd: flexcard: add interrupt support
>   mfd: flexcard: add DMA interrupts
>   mfd: flexcard: add DMA device
>   mfd: flexcard: add UIO IRQ devices
>   misc: Flexcard misc device support
>   misc: flexcard: add device attributes
>   misc: Flexcard basic timestamp counter support
>   misc: flexcard: Support timestamp trigger selection
>   dma: Flexcard DMA ringbuffer demux driver
> 
>  drivers/dma/Kconfig                 |   9 +
>  drivers/dma/Makefile                |   1 +
>  drivers/dma/flexcard/Makefile       |   2 +
>  drivers/dma/flexcard/core.c         | 292 ++++++++++++++++++++++
>  drivers/dma/flexcard/flexcard-dma.h | 218 +++++++++++++++++
>  drivers/dma/flexcard/parser.c       | 227 +++++++++++++++++

>  drivers/mfd/Kconfig                 |  14 ++
>  drivers/mfd/Makefile                |   3 +
>  drivers/mfd/flexcard_core.c         | 476 ++++++++++++++++++++++++++++++++++++
>  drivers/mfd/flexcard_irq.c          | 305 +++++++++++++++++++++++
>  include/linux/mfd/flexcard.h        | 116 +++++++++

Place all of this in one patch to aid review.

>  drivers/misc/Kconfig                |  15 ++
>  drivers/misc/Makefile               |   2 +
>  drivers/misc/flexcard_misc.c        | 361 +++++++++++++++++++++++++++
>  drivers/misc/flexcard_posixclock.c  | 295 ++++++++++++++++++++++
>  include/uapi/linux/Kbuild           |   1 +
>  include/uapi/linux/flexcard.h       |  80 ++++++
>  17 files changed, 2417 insertions(+)
>  create mode 100644 drivers/dma/flexcard/Makefile
>  create mode 100644 drivers/dma/flexcard/core.c
>  create mode 100644 drivers/dma/flexcard/flexcard-dma.h
>  create mode 100644 drivers/dma/flexcard/parser.c
>  create mode 100644 drivers/mfd/flexcard_core.c
>  create mode 100644 drivers/mfd/flexcard_irq.c
>  create mode 100644 drivers/misc/flexcard_misc.c
>  create mode 100644 drivers/misc/flexcard_posixclock.c
>  create mode 100644 include/linux/mfd/flexcard.h
>  create mode 100644 include/uapi/linux/flexcard.h
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog