linux-kernel - Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170104103308.GV27589@dell>
Date:   Wed, 4 Jan 2017 10:33:08 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Marek Vasut <marex@...x.de>
Cc:     Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
        linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com,
        linux-input@...r.kernel.org, jic23@...nel.org, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
        harald@...ib.org, stefan.wahren@...e.com,
        fabio.estevam@...escale.com
Subject: Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

On Thu, 08 Dec 2016, Marek Vasut wrote:

> On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote:
> > Add core files for low resolution analog-to-digital converter (mxs-lradc)
> > MFD driver.
> > 
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@...il.com>
> 
> Just a nit below.
> 
> > +++ b/include/linux/mfd/mxs-lradc.h
> > @@ -0,0 +1,187 @@
> > +/*
> 
> [...]
> 
> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_EN_MASK	(0x1fff << 16)
> > +#define LRADC_CTRL1_MX23_LRADC_IRQ_EN_MASK	(0x01ff << 16)
> > +#define LRADC_CTRL1_LRADC_IRQ_EN_OFFSET		16
> > +#define LRADC_CTRL1_TOUCH_DETECT_IRQ		BIT(8)
> > +#define LRADC_CTRL1_LRADC_IRQ(n)		(1 << (n))
> 
> This would turn into BIT(n) , no ?

Once you have fixed this, you can apply my:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK		0x1fff
> > +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK		0x01ff
> > +#define LRADC_CTRL1_LRADC_IRQ_OFFSET		0
> 
> [...]
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog