linux-kernel - Re: [PATCH 2/3] scsi: hisi_sas: lock sensitive regions when servicing CQ interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e36ec8b-fc52-3f9c-4a34-9b3c8c2efa6e@linaro.org>
Date:   Wed, 4 Jan 2017 09:19:51 +0800
From:   zhangfei <zhangfei.gao@...aro.org>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, xuwei5@...ilicon.com, john.garry2@...l.dcu.ie,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        hanjun.guo@...aro.org
Subject: Re: [PATCH 2/3] scsi: hisi_sas: lock sensitive regions when servicing
 CQ interrupt



On 2017年01月03日 20:24, John Garry wrote:
> There is a bug in the current driver in that certain hisi_hba
> and port structure elements which we access when servicing
> the CQ interrupt do not use thread-safe accesses; these include
> hisi_sas_port linked-list of active slots (hisi_sas_port.entry),
> bitmap of currently allocated IPTT (in hisi_hba.slot_index_tags),
> and completion queue read pointer.
>
> As a solution, lock these elements with the hisi_hba.lock.
>
> Signed-off-by: John Garry <john.garry@...wei.com>
> Reviewed-by: Xiang Chen <chenxiang66@...ilicon.com>
Reviewed-by: Zhangfei Gao <zhangfei.gao@...aro.org>