linux-kernel - Re: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1701041315020.28985@cbobk.fhfr.pm>
Date:   Wed, 4 Jan 2017 13:15:09 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Vlastimil Babka <vbabka@...e.cz>
cc:     linux-kernel@...r.kernel.org,
        Matthew Wilcox <mawilcox@...uxonhyperv.com>
Subject: Re: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with
 GFP_KERNEL

On Wed, 4 Jan 2017, Vlastimil Babka wrote:

> The raw_cmd_copyin() function does a kmalloc() with GFP_USER, although the
> allocated structure is obviously not mapped to userspace, just copied from/to.
> In this case GFP_KERNEL is more appropriate, so let's use it, although in the
> current implementation this does not manifest as any error.
> 
> Reported-by: Matthew Wilcox <mawilcox@...uxonhyperv.com>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs