linux-kernel - Re: [PATCH v4] sparc64: Multi-page size support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9870606-812c-5efe-bc35-ea31fac303a6@oracle.com>
Date:   Tue, 3 Jan 2017 17:22:39 -0800
From:   Nitin Gupta <nitin.m.gupta@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     mike.kravetz@...cle.com, akpm@...ux-foundation.org,
        kirill.shutemov@...ux.intel.com, julian.calaby@...il.com,
        hughd@...gle.com, adam.buchbinder@...il.com, minchan@...nel.org,
        sfr@...b.auug.org.au, paul.gortmaker@...driver.com,
        thomas.tai@...cle.com, chris.hyser@...cle.com,
        atish.patra@...cle.com, mhocko@...e.com,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] sparc64: Multi-page size support



On 12/27/2016 09:34 AM, David Miller wrote:
> From: Nitin Gupta <nitin.m.gupta@...cle.com>
> Date: Tue, 13 Dec 2016 10:03:18 -0800
> 
>> +static unsigned int sun4u_huge_tte_to_shift(pte_t entry)
>> +{
>> +	unsigned long tte_szbits = pte_val(entry) & _PAGE_SZALL_4V;
>> +	unsigned int shift;
>> +
>> +	switch (tte_szbits) {
>> +	case _PAGE_SZ256MB_4U:
>> +		shift = HPAGE_256MB_SHIFT;
>> +		break;
> 
> You added all the code necessary to do this on the sun4u chips that support
> 256MB TTEs, so you might as well enable it in the initialization code.
> 
> I'm pretty sure this is an UltraSPARC-IV and later feature.
> 

I added sun4u related changes just for completeness sake. I don't have
access to a sun4u machine so can't be sure if sun4u would work.
That's why that _PAGE_SZALL_4V typo escaped my notice.

I will enable setup_hugepagesz() for non-hypervisor case and send a v5.

Thanks,
Nitin