linux-kernel - Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m

Open Source and information security mailing list archives

Message-ID: <CAKb7UvhF_S3j+EQJkB7AGq2juzNxYJpWBLcVa1nDketEzaDFpw@mail.gmail.com>
Date:   Wed, 4 Jan 2017 09:25:33 -0500
From:   Ilia Mirkin <imirkin@...m.mit.edu>
To:     Randy Dunlap <rdunlap@...radead.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kbuild test robot <fengguang.wu@...el.com>,
        Ben Skeggs <bskeggs@...hat.com>
Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m

On Wed, Jan 4, 2017 at 3:45 AM, Daniel Vetter <daniel@...ll.ch> wrote:
> On Sun, Jan 01, 2017 at 04:20:53PM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build errors in nouveau driver when CONFIG_LEDS_CLASS=m and
>> CONFIG_DRM_NOUVEAU=y.
>> If LEDS_CLASS is enabled, DRM_NOUVEAU is restricted to the same
>> kconfig value as LEDS_CLASS.
>>
>> drivers/built-in.o: In function `nouveau_do_suspend':
>> nouveau_drm.c:(.text+0x2030b1): undefined reference to `nouveau_led_suspend'
>> drivers/built-in.o: In function `nouveau_do_resume':
>> nouveau_drm.c:(.text+0x2034ca): undefined reference to `nouveau_led_resume'
>> drivers/built-in.o: In function `nouveau_drm_unload':
>> nouveau_drm.c:(.text+0x203a15): undefined reference to `nouveau_led_fini'
>> drivers/built-in.o: In function `nouveau_drm_load':
>> nouveau_drm.c:(.text+0x204423): undefined reference to `nouveau_led_init'
>>
>> BTW, this line in Kbuild:
>> nouveau-$(CONFIG_LEDS_CLASS) += nouveau_led.o
>> does nothing when CONFIG_LEDS_CLASS=m and CONFIG_DRM_NOUVEAU=y.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Reported-by: kbuild test robot <fengguang.wu@...el.com>
>> Cc: Martin Peres <martin.peres@...e.fr>
>> Cc: Ben Skeggs <bskeggs@...hat.com>
>
> Thrown into drm-misc, thanks.
> -Daniel

Wasn't there already a different solution from Martin for this, using
IS_REACHABLE, instead of adding a dependency in Kconfig?

>
>> ---
>>  drivers/gpu/drm/nouveau/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- lnx-410-rc2.orig/drivers/gpu/drm/nouveau/Kconfig
>> +++ lnx-410-rc2/drivers/gpu/drm/nouveau/Kconfig
>> @@ -1,6 +1,7 @@
>>  config DRM_NOUVEAU
>>       tristate "Nouveau (NVIDIA) cards"
>>       depends on DRM && PCI
>> +     depends on LEDS_CLASS || LEDS_CLASS=n
>>          select FW_LOADER
>>       select DRM_KMS_HELPER
>>       select DRM_TTM
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives