linux-kernel - Re: [PATCHv7 8/8] printk: convert the rest to printk-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2017 17:28:25 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>, Tejun Heo <tj@...nel.org>,
        Calvin Owens <calvinowens@...com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCHv7 8/8] printk: convert the rest to printk-safe

On Tue 2016-12-27 23:16:11, Sergey Senozhatsky wrote:
> This patch converts the rest of logbuf users (which are
> out of printk recursion case, but can deadlock in printk).
> To make printk-safe usage easier the patch introduces 4
> helper macros:
> - logbuf_lock_irq()/logbuf_unlock_irq()
>   lock/unlock the logbuf lock and disable/enable local IRQ
> 
> - logbuf_lock_irqsave(flags)/logbuf_unlock_irqrestore(flags)
>   lock/unlock the logbuf lock and saves/restores local IRQ state
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

I like that it is so straigforward using the new macros. It is great
that you discovered this before we finished the patchset.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr

PS: All patches look fine to me. I am going to do some tests before
I could say a final word. I guess that it will be fine and we will
be able to push it to linux-next.