linux-kernel - Re: [PATCH] clk: clk-conf: Do not print error messages if EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8883314-c166-e904-dcb2-dc62d7200997@gmail.com>
Date:   Wed, 4 Jan 2017 13:39:38 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: clk-conf: Do not print error messages if
 EPROBE_DEFER

On 01/04/2017 11:12 AM, Geert Uytterhoeven wrote:
> EPROBE_DEFER is not an error, hence printing an error message like
> 
> 	clk: couldn't get clock 0 for /soc/display@...00000
> 
> may confuse the user.
> 
> Suppress error messages in case of probe deferral to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
>  drivers/clk/clk-conf.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
> index 674785d968a3e1c5..e0e02a6e59009e7a 100644
> --- a/drivers/clk/clk-conf.c
> +++ b/drivers/clk/clk-conf.c
> @@ -40,8 +40,9 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier)
>  			return 0;
>  		pclk = of_clk_get_from_provider(&clkspec);
>  		if (IS_ERR(pclk)) {
> -			pr_warn("clk: couldn't get parent clock %d for %s\n",
> -				index, node->full_name);
> +			if (PTR_ERR(pclk) != -EPROBE_DEFER)
> +				pr_warn("clk: couldn't get parent clock %d for %s\n",
> +					index, node->full_name);
>  			return PTR_ERR(pclk);
>  		}
>  
> @@ -55,8 +56,9 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier)
>  		}
>  		clk = of_clk_get_from_provider(&clkspec);
>  		if (IS_ERR(clk)) {
> -			pr_warn("clk: couldn't get assigned clock %d for %s\n",
> -				index, node->full_name);
> +			if (PTR_ERR(clk) != -EPROBE_DEFER)
> +				pr_warn("clk: couldn't get assigned clock %d for %s\n",
> +					index, node->full_name);
>  			rc = PTR_ERR(clk);
>  			goto err;
>  		}
> @@ -99,8 +101,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
>  
>  			clk = of_clk_get_from_provider(&clkspec);
>  			if (IS_ERR(clk)) {
> -				pr_warn("clk: couldn't get clock %d for %s\n",
> -					index, node->full_name);
> +				if (PTR_ERR(clk) != -EPROBE_DEFER)
> +					pr_warn("clk: couldn't get clock %d for %s\n",
> +						index, node->full_name);
>  				return PTR_ERR(clk);
>  			}
>  
> 


-- 
Best regards,
Marek Vasut