linux-kernel - Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPj87rPbM2Qm0v8S5++5Qpgv51AWxgTpRoAXaY8-CL2_hCSC6g@mail.gmail.com>
Date:   Wed, 4 Jan 2017 17:02:57 +0000
From:   Daniel Stone <daniel@...ishbar.org>
To:     Randy Li <ayaka@...lik.info>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Li Randy <randy.li@...k-chips.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Vetter, Daniel" <daniel.vetter@...el.com>, mchehab@...nel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format

Hi Randy,

On 4 January 2017 at 16:29, Randy Li <ayaka@...lik.info> wrote:
> index 90d2cc8..23c8e99 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 format)
>                 { .format = DRM_FORMAT_UYVY,            .depth = 0,  .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 },
>                 { .format = DRM_FORMAT_VYUY,            .depth = 0,  .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 },
>                 { .format = DRM_FORMAT_AYUV,            .depth = 0,  .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1 },
> +               /* FIXME a pixel in Y for P010 is 10 bits */
> +               { .format = DRM_FORMAT_P010,            .depth = 0,  .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 },

It seems like P010 stores each Y component in a 16-bit value, with the
bottom 6 bits ignored. So I think cpp here should be 2.

Cheers,
Daniel