linux-kernel - Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a40436a-ebad-8a94-c5c5-546ba33ba545@gmail.com>
Date:   Wed, 4 Jan 2017 09:27:35 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        vivien.didelot@...oirfairelinux.com,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA
 binding

On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
> Hi Florian,
>  
>  On lun., janv. 02 2017, Florian Fainelli <f.fainelli@...il.com> wrote:
> 
>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>> dsa: Document new binding"). The legacy binding node is kept included, but is
>> marked disabled.
>>
> 
> I tested this patch on mvebu/dt (I needed to reduce the context to apply
> the patch due to the changes made by Russell King on this file). I also
> set the status of the old binding to "disable" (instead of "okay").

Yes, that needs fixing, thanks for mentioning that.

> 
> It seems to work with the limited test did:
> ifconfig eth1 up
> udhcpc -i lan1
> iperf -c mylaptop
> 
> (same for lan4)
> 
> However is there a way to be sure that the new binding is used?

The best way is probably to make sure that your switch device appears
parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
Alternatively, if you see a message like:

DSA: switch 0 0 parsed

in your dmesg, that would also be indicative of using the new binding
and corresponding code.

Thanks a lot for trying that out!
-- 
Florian