linux-kernel - Re: [PATCH v2] tools: perf: fix linker error when libelf config is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3634d760-c2de-f73d-0a54-afa5b19489ed@arm.com>
Date:   Wed, 4 Jan 2017 17:26:06 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH v2] tools: perf: fix linker error when libelf config is
 disabled



On 04/01/17 17:19, Jiri Olsa wrote:
> On Wed, Jan 04, 2017 at 04:18:10PM +0000, Sudeep Holla wrote:
>>
>>
>> On 04/01/17 16:08, Sudeep Holla wrote:
>>>
>>>
>>> On 04/01/17 16:06, Jiri Olsa wrote:
>>>> On Wed, Jan 04, 2017 at 03:56:03PM +0000, Sudeep Holla wrote:
>>>>> When libelf is disabled in the configuration, we get the following
>>>>> linker error:
>>>>>   LINK     libperf-jvmti.so
>>>>>   ld: cannot find -lelf
>>>>>   Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed
>>>>>
>>>>> Jiri pointed out that both librt and libelf are not really required. So
>>>>> this patch fixes the linker error by getting rid of unwanted libraries
>>>>> in the linker stage.
>>>>>
>>>>> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
>>>>
>>>> hum, AFAICS it linked -lelf and -lrt even before right? ;-)
>>>>
>>>
>>> Yes, sorry I forgot to remove that and trace it back the actual commit.
>>>
>>
>> Having looked at it again, it looks new additions in the above commit.
>> It may be a copied from somewhere else but I can't trace it back :(.
>> I need your help if you want to get rid of that ;)
> 
> I think it's this one:
>   209045adc2bb perf tools: add JVMTI agent library

Thanks for that, I would never have figured this out myself. Will fix
that and send out v3.

-- 
Regards,
Sudeep