linux-kernel - Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170104185846.GB40341@dtor-ws>
Date:   Wed, 4 Jan 2017 10:58:46 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Simon Budig <simon.budig@...nelconcepts.de>
Cc:     Aniroop Mathur <aniroop.mathur@...il.com>,
        Aniroop Mathur <a.mathur@...sung.com>,
        daniel.wagener@...nelconcepts.de, LW@...o-electronics.de,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        SAMUEL SEQUEIRA <s.samuel@...sung.com>,
        Rahul Mahale <r.mahale@...sung.com>
Subject: Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to
 usleep_range for small msecs

On Wed, Jan 04, 2017 at 07:19:56PM +0100, Simon Budig wrote:
> On 03/12/16 19:17, Aniroop Mathur wrote:
> > Since here we are using msleep(1) which is worse as it sleeps for
> > minimum two jiffies so 20 ms on HZ=100 system and we are doing here
> > 100 retries if register reading fails. So as you can deduce usleep_range
> > will serve better here.
> > Explained originally here why to not use msleep for 1-20ms:
> > http://lkml.org/lkml/2007/8/3/250
> 
> Acked-by: Simon Budig <simon.budig@...nelconcepts.de>

Applied, thank you.

> 
> Bye,
>         Simon
> -- 
>      kernel concepts GmbH                 Simon Budig
>      Sieghuetter Hauptweg 48              simon.budig@...nelconcepts.de
>      D-57072 Siegen                       +49-271-771091-17
>      http://www.kernelconcepts.de/
>      HR Siegen, HR B 9613; Geschäftsführer: Nils Faerber, Ole Reinhardt
> 
> 




-- 
Dmitry