linux-kernel - Re: [PATCH v2] fscrypt: Factor out bio specific functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170104201043.GA21696@gmail.com>
Date:   Wed, 4 Jan 2017 12:10:43 -0800
From:   Eric Biggers <ebiggers3@...il.com>
To:     Theodore Ts'o <tytso@....edu>, Richard Weinberger <richard@....at>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        jaegeuk@...nel.org, hch@...radead.org, arnd@...db.de,
        dedekind1@...il.com, linux-mtd@...ts.infradead.org,
        adrian.hunter@...el.com, linux-ext4@...r.kernel.org,
        ebiggers@...gle.com, rdunlap@...radead.org, david@...ma-star.at
Subject: Re: [PATCH v2] fscrypt: Factor out bio specific functions

On Tue, Jan 03, 2017 at 09:28:36AM -0500, Theodore Ts'o wrote:
> On Tue, Jan 03, 2017 at 10:49:26AM +0100, Richard Weinberger wrote:
> > Ted,
> > 
> > Am 01.01.2017 um 22:47 schrieb Theodore Ts'o:
> > > On Mon, Dec 19, 2016 at 12:25:32PM +0100, Richard Weinberger wrote:
> > >> That way we can get rid of the direct dependency on CONFIG_BLOCK.
> > >>
> > >> Reported-by: Arnd Bergmann <arnd@...db.de>
> > >> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > >> Suggested-by: Christoph Hellwig <hch@...radead.org>
> > >> Fixes: d475a507457b ("ubifs: Add skeleton for fscrypto")
> > >> Signed-off-by: Richard Weinberger <richard@....at>
> > > 
> > > Applied, thanks.
> > 
> > Just to make sure, this fixes a build error and should
> > go into Linus' tree ASAP.
> 
> I didn't consider this a build error since it could be fixed via a
> config change.  And it is a pretty big patch, even if it is mostly
> moving (not that git recognized it as such)...
> 

I thought you're supposed to be able to build the kernel no matter how it's
configured.  If this patch is really too large for 4.10 then perhaps we should
make FS_ENCRYPTION select CONFIG_BLOCK instead?

Eric