linux-kernel - Re: [PATCH v2 2/2] phy: sun4i-usb: Replace the deprecated extcon API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64BCKWFP595M0Z+ysLwsRMp05jahFzywx+-QDfhPwTjhg@mail.gmail.com>
Date:   Thu, 5 Jan 2017 14:42:15 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-renesas-soc@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        chanwoo@...nel.org
Subject: Re: [PATCH v2 2/2] phy: sun4i-usb: Replace the deprecated extcon API

On Fri, Dec 30, 2016 at 12:11 PM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_set_state_sync()
>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>

Acked-by: Chen-Yu Tsai <wens@...e.org>

> ---
>  drivers/phy/phy-sun4i-usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
> index bf28a0fdd569..eae171e18043 100644
> --- a/drivers/phy/phy-sun4i-usb.c
> +++ b/drivers/phy/phy-sun4i-usb.c
> @@ -534,7 +534,7 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work)
>         mutex_unlock(&phy0->mutex);
>
>         if (id_notify) {
> -               extcon_set_cable_state_(data->extcon, EXTCON_USB_HOST,
> +               extcon_set_state_sync(data->extcon, EXTCON_USB_HOST,
>                                         !id_det);
>                 /* When leaving host mode force end the session here */
>                 if (force_session_end && id_det == 1) {
> @@ -547,7 +547,7 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work)
>         }
>
>         if (vbus_notify)
> -               extcon_set_cable_state_(data->extcon, EXTCON_USB, vbus_det);
> +               extcon_set_state_sync(data->extcon, EXTCON_USB, vbus_det);
>
>         if (sun4i_usb_phy0_poll(data))
>                 queue_delayed_work(system_wq, &data->detect, POLL_TIME);
> --
> 1.9.1
>