linux-kernel - Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170105010121.GB480@jagdpanzerIV.localdomain>
Date:   Thu, 5 Jan 2017 10:01:21 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>, Tejun Heo <tj@...nel.org>,
        Calvin Owens <calvinowens@...com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi
 contexts

On (01/04/17 15:46), Petr Mladek wrote:
> On Tue 2016-12-27 23:16:08, Sergey Senozhatsky wrote:
> > Account lost messages in pritk-safe and printk-safe-nmi
> > contexts and report those numbers during printk_safe_flush().
> > 
> > The patch also moves lost message counter to struct
> > `printk_safe_seq_buf' instead of having dedicated static
> > counters - this simplifies the code.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> I like that the handling is localized in printk_safe.c and that
> the warning is printed right after the messages that fit the buffer.
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>

thanks.

	-ss