linux-kernel - Re: [PATCH] locking/pvqspinlock: Wait early if vcpu is preempted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <46d0cfa0-888f-648a-b31c-9b760eda3ca2@linux.vnet.ibm.com>
Date:   Thu, 5 Jan 2017 16:44:25 +0800
From:   Pan Xinhui <xinhui@...ux.vnet.ibm.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, longman@...hat.com
Subject: Re: [PATCH] locking/pvqspinlock: Wait early if vcpu is preempted



在 2017/1/5 16:23, Ingo Molnar 写道:
>
> * Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com> wrote:
>
>> If prev node is not in runnig state or its cpu is preempted, we need
>> wait early in pv_wait_node. After commit "sched/core: Introduce the
>> vcpu_is_preempted(cpu) interface" kernel has knowledge of one vcpu is
>> running or not. So lets use it.
>
> That's not how we reference upstream commits. I had to search the git log the hard
> way to figure out that it's commit d9345c65eb79 ...
>
hi, Ingo
	Sorry. Such stupid mistake will not happen next time.

> Also, once you look at that commit you'll see how sloppy the capitalization in
> your changelog is. I fixed that up for all the original commits in the hope of you
> learning from those mistakes - but that was last year and the experiment failed.
>
So sorry, I pay most attention on spelling of words. :(
Maybe I rely on the tools of ./scripts/checkpatch.pl too much.
I will rewrite the comments and resend this patch.

> Thanks,
>
> 	Ingo
>