linux-kernel - RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 05 Jan 2017 11:20:30 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Manish Narani <manish.narani@...inx.com>,
        "robh+dt\@kernel.org" <robh+dt@...nel.org>,
        "mark.rutland\@arm.com" <mark.rutland@....com>,
        "catalin.marinas\@arm.com" <catalin.marinas@....com>,
        "will.deacon\@arm.com" <will.deacon@....com>,
        "michal.simek\@xilinx.com" <michal.simek@...inx.com>,
        Soren Brinkmann <sorenb@...inx.com>,
        "gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
        "mathias.nyman\@intel.com" <mathias.nyman@...el.com>,
        "agraf\@suse.de" <agraf@...e.de>,
        Bharat Kumar Gogada <bharatku@...inx.com>,
        Punnaiah Choudary Kalluri <punnaia@...inx.com>,
        "dhdang\@apm.com" <dhdang@....com>,
        "marc.zyngier\@arm.com" <marc.zyngier@....com>,
        "devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>
Cc:     Anirudha Sarangi <anirudh@...inx.com>,
        Anurag Kumar Vulisha <anuragku@...inx.com>
Subject: RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation


Hi,

Manish Narani <manish.narani@...inx.com> writes:
> Hi Felipe,
>
>
>> From: Felipe Balbi [mailto:balbi@...nel.org]
>> Sent: Wednesday, January 04, 2017 7:01 PM
>> Hi,
>>
>> Manish Narani <manish.narani@...inx.com> writes:
>> > This patch adds support for OTG driver compilation and object file
>> > creation
>> >
>> > Signed-off-by: Manish Narani <mnarani@...inx.com>
>> > ---
>> >  drivers/usb/dwc3/Makefile | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> >
>> > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
>> > index ffca340..2d269ad 100644
>> > --- a/drivers/usb/dwc3/Makefile
>> > +++ b/drivers/usb/dwc3/Makefile
>> > @@ -17,6 +17,10 @@ ifneq ($(filter y,$(CONFIG_USB_DWC3_GADGET)
>> $(CONFIG_USB_DWC3_DUAL_ROLE)),)
>> >     dwc3-y                          += gadget.o ep0.o
>> >  endif
>> >
>> > +ifneq ($(CONFIG_USB_DWC3_DUAL_ROLE),)
>> > +   dwc3-y                          += otg.o
>> > +endif
>>
>> you just broke compilation
>
> Should I add new USB_DWC3_OTG macro in Kconfig?

No, no. Reset your tree to this commit and try to compile it. Problem
should be clear.

> This email and any attachments are intended for the sole use of the
> named recipient(s) and contain(s) confidential information that may be
> proprietary, privileged or copyrighted under applicable law. If you
> are not the intended recipient, do not read, copy, or forward this
> email message or any attachments. Delete this email message and any
> attachments immediately.

you should make sure these notes aren't sent to public mailing
lists. I'll delete this email of yours and stop reading them until this
is sorted out.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)