linux-kernel - Re: [PATCH v6 3/3] serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vft_6_yM7Khjmnv1WYzSZ0rb_UJP-SVay5e3uK1_3YBRA@mail.gmail.com>
Date:   Thu, 5 Jan 2017 16:37:06 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v6 3/3] serial: 8250_pci: remove exar code

On Thu, Jan 5, 2017 at 4:35 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Jan 5, 2017 at 12:20 PM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
>> Remove the exar specific codes from 8250_pci and blacklist those chips
>> so that the exar serial binds to the devices.
>
> exar -> Exar ?
>
>> +#define PCI_DEVICE_ID_COMMTECH_4222PCI335 0x0004
>> +#define PCI_DEVICE_ID_COMMTECH_4224PCI335 0x0002
>> +#define PCI_DEVICE_ID_COMMTECH_2324PCI335 0x000a
>> +#define PCI_DEVICE_ID_COMMTECH_2328PCI335 0x000b
>
> This is not related to the patch. Create a separate one.
>
>> @@ -3734,6 +3538,8 @@ enum pci_board_num_t {
>>         { PCI_VDEVICE(INTEL, 0x228c), },
>>         { PCI_VDEVICE(INTEL, 0x9ce3), },
>>         { PCI_VDEVICE(INTEL, 0x9ce4), },
>
> + empty line
>
>> +       /* Exar devices */
>> +       { PCI_VDEVICE(EXAR, PCI_ANY_ID), },
>>  };

Ah, one more. Set default for your new driver to be SERIAL_8250.
Otherwise users will lost it, right?

-- 
With Best Regards,
Andy Shevchenko