linux-kernel - [PATCH] Staging: braille_console: fixed 3 warn, 1 err (using checkpatch)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170105000725.6p224dn2zck6dsu4@yoda>
Date:   Thu, 5 Jan 2017 01:07:25 +0100
From:   Olaf Luijks <oluijks@...il.com>
To:     linux-kernel@...r.kernel.org
Subject: [PATCH] Staging: braille_console: fixed 3 warn, 1 err (using
 checkpatch)

Fixed some coding style issues.

- ERROR: Use 4 digit octal (0777) not decimal permissions (48)
- WARNING: Missing a blank line after declarations (241, 280, 288)

Signed-off-by: Olaf Luijks <oluijks@...il.com>
---
 drivers/accessibility/braille/braille_console.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
index dc34a5b..340fda0 100644
--- a/drivers/accessibility/braille/braille_console.c
+++ b/drivers/accessibility/braille/braille_console.c
@@ -45,7 +45,7 @@ MODULE_LICENSE("GPL");
 
 /* Emit various sounds */
 static bool sound;
-module_param(sound, bool, 0);
+module_param(sound, bool, 0000);
 MODULE_PARM_DESC(sound, "emit sounds");
 
 static void beep(unsigned int freq)
@@ -238,6 +238,7 @@ static int keyboard_notifier_call(struct notifier_block *blk,
 	case KBD_POST_KEYSYM:
 	{
 		unsigned char type = KTYP(param->value) - 0xf0;
+
 		if (type == KT_SPEC) {
 			unsigned char val = KVAL(param->value);
 			int on_off = -1;
@@ -277,6 +278,7 @@ static int vt_notifier_call(struct notifier_block *blk,
 {
 	struct vt_notifier_param *param = _param;
 	struct vc_data *vc = param->vc;
+
 	switch (code) {
 	case VT_ALLOCATE:
 		break;
@@ -285,6 +287,7 @@ static int vt_notifier_call(struct notifier_block *blk,
 	case VT_WRITE:
 	{
 		unsigned char c = param->c;
+
 		if (vc->vc_num != fg_console)
 			break;
 		switch (c) {
-- 
2.9.0