linux-kernel - Re: [PATCH 1/1] spi: imx: support to set watermark level via DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170105175854.gj5xr5drk5tddzyz@sirena.org.uk>
Date:   Thu, 5 Jan 2017 17:58:54 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jiada Wang <jiada_wang@...tor.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] spi: imx: support to set watermark level via DTS

On Thu, Jan 05, 2017 at 03:10:15PM +0900, Jiada Wang wrote:

> Previously watermark level is configured to fifosize/2,
> DMA mode can be used only when transfer length can be divided
> by 'watermark level * bpw', which makes DMA mode not practical.

> This patch adds new DTS property 'dma-wml', user can configure
> DMA watermark level, by specify 'dma-wml' in corresponding ecspi
> node.

Doesn't this just move the problem around a bit - can we not have the
driver figure out a more sensible watermark for each transfer rather
than fixing one in the DT?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)