linux-kernel - Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdD_u0NOixwkEekiF71RDfddkAkJGaKqBhETBwDPA3_1g@mail.gmail.com>
Date:   Thu, 5 Jan 2017 20:09:05 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Hoegeun Kwon <hoegeun.kwon@...sung.com>
Cc:     robh@...nel.org, thierry.reding@...il.com, airlied@...ux.ie,
        kgene@...nel.org, Inki Dae <inki.dae@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        a.hajda@...sung.com, Chanwoo Choi <cw00.choi@...sung.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Donghwa Lee <dh09.lee@...sung.com>,
        Hyungwon Hwang <human.hwang@...sung.com>
Subject: Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on
 TM2 board

On Thu, Jan 5, 2017 at 12:20 PM, Hoegeun Kwon <hoegeun.kwon@...sung.com> wrote:
> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel
> driver. This panel has 1440x2560 resolution in 5.7-inch physical
> panel in the TM2 device.
>
> Signed-off-by: Donghwa Lee <dh09.lee@...sung.com>
> Signed-off-by: Hyungwon Hwang <human.hwang@...sung.com>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
> Tested-by: Chanwoo Choi <cw00.choi@...sung.com>
> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  .../bindings/display/panel/samsung,s6e3ha2.txt     |  28 +
>  drivers/gpu/drm/panel/Kconfig                      |   6 +
>  drivers/gpu/drm/panel/Makefile                     |   1 +
>  drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c      | 754 +++++++++++++++++++++
>  4 files changed, 789 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt
>  create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt
> new file mode 100644
> index 0000000..da4c291

This should be a separate patch, preferably first one in the series. See:
Documentation/devicetree/bindings/submitting-patches.txt
Since you already got reviews and tests, I think you can retain them
in both patches (so dt-bindings patch will have reviewed-by-Andrzej
and the code will have review+tested).

Best regards,
Krzysztof