linux-kernel - Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <927ed4ce-b2a6-699d-9a35-795633484b82@codeaurora.org>
Date:   Thu, 5 Jan 2017 13:58:42 -0800
From:   Sarangdhar Joshi <spjoshi@...eaurora.org>
To:     Suman Anna <s-anna@...com>, Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tony Lindgren <tony@...mide.com>
Cc:     linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>,
        Trilok Soni <tsoni@...eaurora.org>,
        Dave Gerlach <d-gerlach@...com>
Subject: Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread

On 01/05/2017 01:08 PM, Suman Anna wrote:
> On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
>> The function wkup_m3_rproc_boot_thread waits for
>> asynchronous firmware loading to parse the resource table
>> before calling rproc_boot(). However, as the resource table
>> parsing has been moved to rproc_boot(), there's no need to
>> wait for the asynchronous firmware loading completion.
>> So, drop this.
>>
>> CC: Dave Gerlach <d-gerlach@...com>
>> CC: Suman Anna <s-anna@...com>
>> CC: Bjorn Andersson <bjorn.andersson@...aro.org>
>> Signed-off-by: Sarangdhar Joshi <spjoshi@...eaurora.org>
>
> + Tony and Santosh, not sure who is picking up the wkup_m3 related patches.
>
> Only one minor nit, I would prefer the patch subject to start with
> soc: ti: wkup_m3_ipc: ....

Sure, will update the subject line.

Regards,
Sarang

>
> Tested-by: Suman Anna <s-anna@...com>
>
> regards
> Suman
>
>> ---
>>
>> This patch seems to be doing an independent clean up now. Hence
>> removing it from the series.
>>
>>  drivers/soc/ti/wkup_m3_ipc.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
>> index 8823cc8..8bfa44b 100644
>> --- a/drivers/soc/ti/wkup_m3_ipc.c
>> +++ b/drivers/soc/ti/wkup_m3_ipc.c
>> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>>  	struct device *dev = m3_ipc->dev;
>>  	int ret;
>>
>> -	wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
>> -
>>  	init_completion(&m3_ipc->sync_complete);
>>
>>  	ret = rproc_boot(m3_ipc->rproc);
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project