linux-kernel - Re: [PATCH] sysrq: attach sysrq handler correctly for 32-bit kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170105221444.GA20478@dtor-ws>
Date:   Thu, 5 Jan 2017 14:14:44 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Akinobu Mita <akinobu.mita@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH] sysrq: attach sysrq handler correctly for 32-bit kernel

On Fri, Jan 06, 2017 at 02:14:16AM +0900, Akinobu Mita wrote:
> The sysrq input handler should be attached to the input device which has
> a left alt key.
> 
> On 32-bit kernels, some input devices which has a left alt key cannot
> attach sysrq handler.  Because the keybit bitmap in struct input_device_id
> for sysrq is not correctly initialized.  KEY_LEFTALT is 56 which is
> greater than BITS_PER_LONG on 32-bit kernels.
> 
> I found this problem when using a matrix keypad device which defines
> a KEY_LEFTALT (56) but doesn't have a KEY_O (24 == 56%32).
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

I guess Greg will take it through TTY tree. Might go to stable as well,
although apparently not pressing since it was only noticed now.

> ---
>  drivers/tty/sysrq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 52bbd27..701c085 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -946,8 +946,8 @@ static const struct input_device_id sysrq_ids[] = {
>  	{
>  		.flags = INPUT_DEVICE_ID_MATCH_EVBIT |
>  				INPUT_DEVICE_ID_MATCH_KEYBIT,
> -		.evbit = { BIT_MASK(EV_KEY) },
> -		.keybit = { BIT_MASK(KEY_LEFTALT) },
> +		.evbit = { [BIT_WORD(EV_KEY)] = BIT_MASK(EV_KEY) },
> +		.keybit = { [BIT_WORD(KEY_LEFTALT)] = BIT_MASK(KEY_LEFTALT) },
>  	},
>  	{ },
>  };
> -- 
> 2.7.4
> 

Thanks.

-- 
Dmitry