linux-kernel - Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLVunQRZkQtG3u2X=igv-e7VAm6=ZbgyXj4mGSJjnBpcFQ@mail.gmail.com>
Date:   Fri, 6 Jan 2017 13:52:52 -0800
From:   John Stultz <john.stultz@...aro.org>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     John Youn <johnyoun@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Guodong Xu <guodong.xu@...aro.org>,
        Zhangfei Gao <zhangfei.gao@...aro.org>
Subject: Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan <leo.yan@...aro.org> wrote:
> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params")
> changes to type u16 for DT binding "g-rx-fifo-size" and
> "g-np-tx-fifo-size" but use type u32 for "g-tx-fifo-size". Finally the
> the first two parameters cannot be passed successfully with wrong data
> format. This is found the data transferring broken on 96boards Hikey.
>
> This patch is to change all parameters to u32 type, and verified on
> Hikey board the DT parameters can pass successfully.
>
> Signed-off-by: Leo Yan <leo.yan@...aro.org>

Nice!

This patch (while it doesn't apply cleanly to v4.10-rc2) does resolve
the regression I reported earlier here:
https://www.spinics.net/lists/linux-usb/msg150766.html

I didn't see the slight shift to u16s there.

Leo, does the patch need a respin, or is it against Linus' HEAD and my
tree is stale?

Anyway, after re-applying it to my tree:
Tested-by: John Stultz <john.stultz@...aro.org>

thanks
-john