linux-kernel - Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170106234626.24f5f6ad@wiggum>
Date:   Fri, 6 Jan 2017 23:46:26 +0100
From:   Michael Büsch <m@...s.ch>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     Rahul Krishnan <mrahul.krishnan@...il.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ssb: main.c: This patch removes unnecessary return
 statement using spatch tool

> > @@ -1272,9 +1272,7 @@ u32 ssb_admatch_size(u32 adm)
> >         default:
> >                 SSB_WARN_ON(1);
> >         }
> > -       size = (1 << (size + 1));
> > -
> > -       return size;
> > +       return (1 << (size + 1));
> >  }
> >  EXPORT_SYMBOL(ssb_admatch_size);  

I'm all for cleaning up code, but I don't really see how this
change improves the code.

-- 
Michael

Content of type "application/pgp-signature" skipped