linux-kernel - Re: [PATCH] lib/vsprintf.c: remove %Z support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170105160748.1f3696c51cd4e56de132243d@linux-foundation.org>
Date:   Thu, 5 Jan 2017 16:07:48 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux@...musvillemoes.dk
Subject: Re: [PATCH] lib/vsprintf.c: remove %Z support

On Wed, 4 Jan 2017 02:01:27 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:

> Now that %z is standartised in C99 there is no reason to support %Z.
> Unlike %L it doesn't even make format strings smaller.
> 
> Use BUILD_BUG_ON in a couple ATM drivers.
> 
> In case anyone didn't notice lib/vsprintf.o is about half of SLUB
> which is in my opinion is quite an achievement. Hopefully this patch
> inspires someone else to trim vsprintf.c more.

There's a risk that more %Z uses will sneak into the tree during the
4.10 development cycle, and possibly even later.  So I added a
note-to-self to re-grep the tree before sending this upstream, but that
won't prevent people adding new instances later on: code which was
tested under earlier kernels which has %Z support.

The best suggestion I have is to add a checkpatch rule to try to catch
new %Z's being added.