linux-kernel - Re: [PATCH] HID: remove use of DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170106080637.GD15702@mail.corp.redhat.com>
Date:   Fri, 6 Jan 2017 09:06:37 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Grant Grundler <grundler@...omium.org>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Dmitry Torokhov <dtor@...omium.org>,
        linux-input <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-usb <linux-usb@...r.kernel.org>,
        Grant Grundler <grundler@...gle.com>
Subject: Re: [PATCH] HID: remove use of DRIVER_LICENSE

On Jan 05 2017 or thereabouts, Grant Grundler wrote:
> Local "#define DRIVER_LICENSE" obfuscates which license is used
> in MODULE_LICENSE().  "fgrep -R MODULE_LICENSE" is more informative
> when the string is hard coded in MODULE_LICENSE.
> 
> Signed-off-by: Grant Grundler <grundler@...gle.com>
> ---
> Most of the kernel already uses hard coded strings.
> The few places that don't are easy to fix.

FWIW:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>