lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 06 Jan 2017 18:25:41 +0900 From: Andi Shyti <andi.shyti@...sung.com> To: Krzysztof Kozlowski <krzk@...nel.org> Cc: Jaechul Lee <jcsing.lee@...sung.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Kukjin Kim <kgene@...nel.org>, Javier Martinez Canillas <javier@....samsung.com>, Chanwoo Choi <cw00.choi@...sung.com>, beomho.seo@...sung.com, galaxyra@...il.com, linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org Subject: Re: [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Hi Krzysztof, > > > > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1118 +++++++++++++++++++ > > > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1153 +------------------- > > > > > > Like talking to a wall. Without any feedback. If my instructions were > > > wrong (and it is not possible to detect rename) then please say it (you > > > can add personal comments after separator ---). > > > > no Krzysztof, I'm sorry, but this patch has been formatted with > > the diff algorithm *you* asked, -B50% both version 2 (where you > > didn't comment) and version 3. If you still don't like it, please > > don't blame me, blame the algorithm. > > If you wrote it in cover letter or after '---' I wouldn't complain > because I would know that my feedback was ignored. But here it is like > black hole - I do not know whether I was ignored or it was not working. In the cover letter is written: "- patch 3 diff has been generated with -B50%" in "Changes in v2:". In v3 patch 3 has become patch 2. > > Now we can stay here at trying random diff algorithms (as they > > give more or less the same result) or you tell me which exact > > algorithm you want me to use. Besides, for me it's clear, > > tm2-common is all new, while in tm2 you have on one side the '-' > > (if it applies nothing has changed) on the bottom the '+'. > > Maybe that depends on the git? > $ git --version > git version 2.9.3 > $ git format-patch -2 -B50% > ... > 21 ...ynos5433-tm2.dts => exynos5433-tm2-common.dtsi} | 24 +- > 22 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1153 +------------------- > 23 arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 22 +- > 24 3 files changed, 56 insertions(+), 1143 deletions(-) > 25 copy arch/arm64/boot/dts/exynos/{exynos5433-tm2.dts => exynos5433-tm2-common.dtsi} (98%) > 26 rewrite arch/arm64/boot/dts/exynos/exynos5433-tm2.dts (98%) I guess you're right, this has been generated from Jaechul's PC who perhaps has a different version. I have version 2.11.0 and I have same output as you. I will send the patch generated from my PC as reply to your mail. Andi
Powered by blists - more mailing lists