linux-kernel - Re: [PATCH V8 1/9] iommu: add IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170106110627.GO17255@8bytes.org>
Date:   Fri, 6 Jan 2017 12:06:27 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Sricharan R <sricharan@...eaurora.org>
Cc:     jcrouse@...eaurora.org, pdaly@...eaurora.org,
        jgebben@...eaurora.org, linux-kernel@...r.kernel.org,
        pratikp@...eaurora.org, iommu@...ts.linux-foundation.org,
        robin.murphy@....com, tzeng@...eaurora.org,
        linux-arm-kernel@...ts.infradead.org, will.deacon@....com,
        mitchelh@...eaurora.org, vinod.koul@...el.com,
        dan.j.williams@...el.com, linux@...linux.org.uk
Subject: Re: [PATCH V8 1/9] iommu: add IOMMU_PRIV attribute

On Mon, Jan 02, 2017 at 06:42:36PM +0530, Sricharan R wrote:
> From: Mitchel Humpherys <mitchelh@...eaurora.org>
> 
> Add the IOMMU_PRIV attribute, which is used to indicate privileged
> mappings.
> 
> Reviewed-by: Robin Murphy <robin.murphy@....com>
> Tested-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Mitchel Humpherys <mitchelh@...eaurora.org>
> Acked-by: Will Deacon <will.deacon@....com>
> ---
>  include/linux/iommu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 0ff5111..8c15ada 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -31,6 +31,7 @@
>  #define IOMMU_CACHE	(1 << 2) /* DMA cache coherency */
>  #define IOMMU_NOEXEC	(1 << 3)
>  #define IOMMU_MMIO	(1 << 4) /* e.g. things like MSI doorbells */
> +#define IOMMU_PRIV	(1 << 5) /* privileged */

Since this is a new generic global flag, can you please add a more
verbose comment telling what a 'privileged' mapping is about in the
iommu-case? We should have a clear defined semantic for this flag or we
might end up with different meanings for it with different
iommu-hardware.


	Joerg