linux-kernel - Re: Geode LX AES/RNG driver triggers warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <64A110A1-433C-4903-BDA0-E9E7F9B476CC@sigma-star.at>
Date:   Fri, 6 Jan 2017 14:19:47 +0100
From:   David Gstir <david@...ma-star.at>
To:     PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
Cc:     One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
        linux-geode@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, teheo@...e.de,
        Richard Weinberger <richard@....at>
Subject: Re: Geode LX AES/RNG driver triggers warning

PrasannaKumar,

> On 06.01.2017, at 10:40, PrasannaKumar Muralidharan <prasannatsmkumar@...il.com> wrote:
> 
>>> I narrowed it down to commit 6e9b5e76882c ("hwrng: geode - Migrate to managed API") which seems to introduce this. It looks to me like some issue between devres, the Geode hwrng and AES drivers which both use the same PCI device.
>> 
>> It does
>> 
>>> I'm no expert here, but I curious if this will cause any issues when using the hardware crypto drivers and also what's the best way to get rid of this?
>> 
>> Probably to create an mfd device that turns the PCI device into two MFD
>> devices and bind AES and hwrng one to each MFD device. Take a look in
>> drivers/mfd. That would also fix the uglies in mod_init for the rng
>> driver.
> 
> I am the author of that commit. Code before commit 6e9b5e76882c had
> ioremap, wondering why there was no warning message before. Just want
> to know if that commit uncovered existing issue or introduced a new
> issue? As far as I understand the commit did not change the
> functionality. Please feel free to correct if I have missed something.

This warning is because commit 6e9b5e76882c introduces devres (devm_ioremap vs ioremap). As soon as I have some spare time, I'll look into resolving this via MFD like Alan suggested.

Thanks,
-David